bug#61340: 29.0.60; Extra space in xref buffer

[Dmitry Gutov]

On 08/02/2023 09:35, Juri Linkov wrote:
> close 61340 30.0.50
> thanks
>
> > > @@ -1108,7 +1108,7 @@ xref--insert-xrefs
> > >                                       maximize (xref-location-line
> > >                                                 (xref-item-location xref)))
> > >               for line-format = (and max-line
> > > -                                  (format "%%%dd: " (1+ (floor (log max-line 
> > > 10)))))
> > > +                                  (format "%%%dd:" (1+ (floor (log max-line 
> > > 10)))))
> > >               with item-text-props = (list 'mouse-face 'highlight
> > >                                            'keymap xref--button-map
> > >                                            'help-echo
> > > ```
> > This was originally an effort to give the outputted text some "breathing
> > room", and I think it looks a little better.
> Indeed, it looks better but unfortunately at the cost of caused ambiguity.
> I guess this is the reason why Grep and Occur don't add space.

I suppose we could try to tone down the colon. Occur uses 'shadow' for 
both the number and the colon; Grep uses the color from 'default' (with 
an underline).

If we fontify it with 'shadow' rather than 'xref-line-number', that 
might look a little better.