[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell i
From: |
Yuan Fu |
Subject: |
bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser |
Date: |
Mon, 6 Feb 2023 19:00:30 -0800 |
> On Feb 6, 2023, at 7:21 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Mickey Petersen <mickey@masteringemacs.org>
>> Cc: casouri@gmail.com, 61235@debbugs.gnu.org
>> Date: Mon, 06 Feb 2023 14:08:46 +0000
>>
>> All I want is a way for treesit-node-check to tell me if the node
>> belongs to a dead or alive parser.
>
> That'd be fine by me, but the patch posted by Yuan was a different
> one.
>
> Yuan, any reason not to extend treesit-node-check instead?
I did extend treesit-node-check in the patch. But I also added a function
treesit-parser-live-p, which makes the same check but directly on a parser. It
just made sense to me that if we let treesit-node-check check the nodes’
parser’s status, we’d also add a function to allow directly checking the status
of a parser.
Micky, the function I added (and the extension to treesit-node-check) checks
that the parser is not deleted AND its buffer is live. That makes the most
sense to me, but would it cause any problem for your use case?
Yuan
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Mickey Petersen, 2023/02/02
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Yuan Fu, 2023/02/05
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Eli Zaretskii, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Mickey Petersen, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Eli Zaretskii, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Mickey Petersen, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Eli Zaretskii, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Mickey Petersen, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Eli Zaretskii, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser,
Yuan Fu <=
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Eli Zaretskii, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Yuan Fu, 2023/02/06
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Eli Zaretskii, 2023/02/07
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Yuan Fu, 2023/02/07
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Mickey Petersen, 2023/02/07
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Yuan Fu, 2023/02/07
- bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Mickey Petersen, 2023/02/08
bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser, Yuan Fu, 2023/02/09