[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60505: 29.0.60; Fido Mode and Tramp Completion
From: |
Stefan Monnier |
Subject: |
bug#60505: 29.0.60; Fido Mode and Tramp Completion |
Date: |
Fri, 03 Feb 2023 13:43:07 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> +(defun tramp-completion-handle-expand-file-name (filename &optional
> directory)
> + "Like `expand-file-name' for partial Tramp files."
> + (if (file-name-absolute-p filename)
> + filename
> + (concat (or directory default-directory "/") filename)))
Hmm... shouldn't a "/" may need to be added if `directory` or
`default-directory` doesn't end with one (except in cases like `/ssh:`)?
Then again, maybe not. I don't understand enough of the details of when
`tramp-completion-file-name-handler` is used (IOW what is meant exactly by
"partial Tramp file name").
IIUC the `tramp-completion-file-name*` thingies operate only for
"partial Tramp file name" (so the "completion" part of their name is
technically a misnomer, tho they make sense in practice since this part
of the code is only really important during completion), i.e. file names
that should be handled by Tramp but that are incomplete because they end
before getting to specifying the desired directory/file at the remote
end (or even specifying the remote host's name).
I didn't remember this part of the design, but it sounds good and does
make changes to that part (like the proposed patch) "safer", so it's
probably OK to try it on `master`.
I wonder how this patch interacts with `locate-dominating-file`.
Stefan
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Gregory Heytings, 2023/02/01
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/01
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Gregory Heytings, 2023/02/01
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Eli Zaretskii, 2023/02/02
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/02
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Eli Zaretskii, 2023/02/02
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Stefan Monnier, 2023/02/02
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/03
- bug#60505: 29.0.60; Fido Mode and Tramp Completion,
Stefan Monnier <=
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/03
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Stefan Monnier, 2023/02/03
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/04
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Stefan Monnier, 2023/02/04
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Gregory Heytings, 2023/02/03
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/04
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/06
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Gregory Heytings, 2023/02/06
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Heerdegen, 2023/02/06
- bug#60505: 29.0.60; Fido Mode and Tramp Completion, Michael Albinus, 2023/02/07