bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-


From: Kai Tetzlaff
Subject: bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-manage)
Date: Sun, 22 Jan 2023 03:12:00 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

I've now added an additional patch which automatically handles unix/dos
eol-types when downloading/uploading sieve scripts. So far, if a script
downloaded from the server contained CRLF EOLs, the script buffer was
full of '^M's. With the additional patch
(0005-Autodetect-eol-type-of-sieve-manage-scripts), the EOL type is
detected and used for decoding during script download (and subsequently
also for encoding during upload).

For that, I changed the interface between 'sieve-upload' (in sieve.el),
and 'manage-sieve-putscript' (plus 'sieve-manage-decode' and
'sieve-manage-send' in sieve-manage.el). Instead of transferring the
script data as a string, the functions are now using the actual script
buffer.

The eol-type detection is done in the new function
'sieve-manage--guess-buffer-coding-system'. But I would assume, that
this functionality already exists somewhere else. E.g. 'find-file' must
do a similar, much more detailed analysis. However, that seems to happen
in the C implementation, so it's not directly usable in sieve-manage. Or
am I missing something?


Attachment: 0001-Fix-bug-in-sieve-manage-append-to-log-and-do-some-re.patch
Description: Text Data

Attachment: 0002-Handle-BYE-in-sieve-manage-server-responses.patch
Description: Text Data

Attachment: 0003-Add-test-lisp-net-sieve-manage-tests.el.patch
Description: Text Data

Attachment: 0004-Some-minor-fixes-in-lisp-net-sieve.el.patch
Description: Text Data

Attachment: 0005-Autodetect-eol-type-of-sieve-manage-scripts.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]