[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argumen
From: |
Robert Pluim |
Subject: |
bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument |
Date: |
Thu, 19 Jan 2023 16:27:39 +0100 |
>>>>> On Thu, 19 Jan 2023 12:19:19 +0100, Daniel Mendler
>>>>> <mail@daniel-mendler.de> said:
Daniel> On 1/19/23 12:05, Robert Pluim wrote:
Daniel> My point is that it would be expected from `key-parse' that it is
Daniel> equally strict as the other keymap functions, otherwise we miss bugs
Daniel> where `key-parse' wasn't used properly. Furthermore we would avoid
all
Daniel> these `key-valid-p` and `keymap--check' calls, as I mentioned.
`key-parse' should perhaps be renamed to `key--parse' as itʼs very
much internal.
Daniel> Of course `kbd' should stay as lax as it has always been.
Daniel> It is mostly used internally. There are only 9 call sites in the
Emacs code.
>> Iʼll make
>> that change locally and see what happens. (Update: it did not go well,
>> there are test-suite failures).
Daniel> This is hardly an argument. You should check all the call sites and
Daniel> adjust accordingly. In particular `kbd' must pass 'noerror. I would
Daniel> expect this to be a pretty small patch given the small number of
call sites.
The test suite shows what peopleʼs assumptions are, so such failures
are valuable. It may be enough to use 'noerror in `kbd', indeed, but I
havenʼt checked that yet. Or maybe the test suite needs adjusting.
Robert
--
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, (continued)
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/17
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Daniel Mendler, 2023/01/17
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/18
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Daniel Mendler, 2023/01/18
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Daniel Mendler, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Daniel Mendler, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Daniel Mendler, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument,
Robert Pluim <=
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Daniel Mendler, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Eli Zaretskii, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Eli Zaretskii, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/19
- bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument, Robert Pluim, 2023/01/20