[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60411: 29.0.60; minibuffer-next-completion skips first candidate whe
From: |
Gregory Heytings |
Subject: |
bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil |
Date: |
Sat, 07 Jan 2023 22:35:33 +0000 |
Please remove (= n 1) and replace (setq n 0) with (setq n (1- n)) to
support the prefix arg with ‘M-N M-n’.
When n > 0.
You mean this, right?
diff --git a/lisp/simple.el b/lisp/simple.el
index 63479e9ce0..0221881641 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -9698,6 +9698,14 @@ next-completion
(let ((tabcommand (member (this-command-keys) '("\t" [backtab])))
pos)
(catch 'bound
+ (when (and (bobp)
+ (> n 0)
+ (get-text-property (point) 'mouse-face)
+ (not (get-text-property (point) 'first-completion)))
+ (let ((inhibit-read-only t))
+ (add-text-properties (point) (1+ (point)) '(first-completion t)))
+ (setq n (1- n)))
+
(while (> n 0)
(setq pos (point))
;; If in a completion, move to the end of it.
It took me a few minutes to understand what you meant by "support the
prefix arg" in this case. And indeed with the previous version of the
patch, M-x M-2 M-<down> selects the third completion candidate (2C-split),
whereas with this patch the second one (2C-command) is selected.
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, (continued)
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Stefan Monnier, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Juri Linkov, 2023/01/07
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Juri Linkov, 2023/01/07
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil,
Gregory Heytings <=
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Juri Linkov, 2023/01/08
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/08
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Juri Linkov, 2023/01/12
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Stefan Monnier, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06