[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59888: [PATCH] Add 'grep-heading-mode'
From: |
Augusto Stoffel |
Subject: |
bug#59888: [PATCH] Add 'grep-heading-mode' |
Date: |
Fri, 09 Dec 2022 12:58:49 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
On Fri, 9 Dec 2022 at 09:28, Juri Linkov wrote:
>> +(defface grep-heading '((t :inherit font-lock-function-name-face))
>> + "Face of headings when using `grep-heading-mode'.")
>
> I suggest to keep the existing color scheme, thus inheriting from
> compilation-info. This is the same color used by both grep.el and
> xref.el by default.
Yes, I came to the same conclusion in the meanwhile.
>> +(defvar grep--heading-format
>> + #("\n%s\n" 1 3 (font-lock-face grep-heading outline-level 1))
>
> xref.el doesn't insert extra newlines between file sections.
> It would be nice to keep the output closer to the existing
> output in xref buffers.
Okay, I agree with your reasoning and will make the change. However, I
must say find the result less appealing. Note that, because of the lack
of newlines, xref-file-header was naturally chosen as a heavier face.
But it's all customizable anyway.
bug#59888: [PATCH] Add 'grep-heading-mode', Mattias EngdegÄrd, 2022/12/08
bug#59888: [PATCH] Add 'grep-heading-mode', Juri Linkov, 2022/12/09
- bug#59888: [PATCH] Add 'grep-heading-mode',
Augusto Stoffel <=