[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being cl
From: |
Daniel Martín |
Subject: |
bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed) |
Date: |
Sun, 04 Dec 2022 14:53:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) |
Kai Ma <justksqsf@gmail.com> writes:
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index 507f2a9e7d..f99d7cde3c 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -6703,8 +6703,18 @@ - (BOOL)acceptsFirstResponder
>
> - (void)resetCursorRects
> {
> - NSRect visible = [self visibleRect];
> - NSCursor *currentCursor = FRAME_POINTER_TYPE (emacsframe);
> + NSRect visible;
> + NSCursor *currentCursor;
> +
> + /* FIXME: [resetCursorRects:] can be called from the event loop
> + after the frame is deleted. When this happens,
> + emacsframe->output_data is NULL. This means there is an
> + underlying leak of the EmacsView object! (bug#59794) */
> + if (! emacsframe || ! FRAME_OUTPUT_DATA (emacsframe))
Wouldn't it be more clear to check !FRAME_LIVE_P (emacsframe) instead?
(I can't reproduce this bug, so I don't know if that would avoid the
crash.) There is a similar check in - (void)windowWillExitFullScreen
and - (void)windowDidExitFullScreen, for example.
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed, (continued)
- Message not available
- bug#59794: Acknowledgement (29.0.60; NSport segfaults when a fullscreen frame is being closed), Kai Ma, 2022/12/03
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Eli Zaretskii, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Po Lu, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Eli Zaretskii, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Po Lu, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Eli Zaretskii, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Po Lu, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Kai Ma, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Eli Zaretskii, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed),
Daniel Martín <=
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Kai Ma, 2022/12/04
- bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed), Po Lu, 2022/12/04