[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
From: |
Sean Whitton |
Subject: |
bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat |
Date: |
Sat, 03 Dec 2022 00:04:17 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
On Sun 20 Nov 2022 at 02:58PM -07, Sean Whitton wrote:
> We already have vc-git-log-switches. git-log(1) gets called *without*
> it in (at least) the following places:
>
> - vc-git-log-outgoing
> - vc-git-log-incoming
> - vc-git-log-search
> - vc-git-expanded-log-entry
> - vc-git-region-history
>
> I guess that the first three should probably use vc-git-log-switches if
> anything? And so we would want a separate option for
> vc-git-expanded-log-entry. Not sure about vc-git-region-history.
I think that we actually need two defcustoms for the regular logs and
shortlogs:
- vc-git-print-log -- should choose which defcustom to include based on
its SHORTLOG parameter
- vc-git-log-outgoing -- vc-git-shortlog-switches
- vc-git-log-incoming -- vc-git-shortlog-switches
- vc-git-log-search -- vc-git-log-switches
- vc-git-expanded-log-entry -- vc-git-log-switches
This is because some options are incompatible with shortlogs, such as
--stat. So, the proposed change is to add the new defcustom, change
vc-git-print-log to use both defcustoms, and change all the other
functions to use one of them. How does this sound?
--
Sean Whitton
- bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat,
Sean Whitton <=