bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packages only

[Andrii Kolomoiets]

Philip Kaludercic <philipk@posteo.net> writes:

>>>> +                          ((file-regular-p file)))
>>>
>>> Shouldn't we keep `file-readable-p'?
>>
>> I think we should use `file-regular-p' so even if the pkg-dir will
>> contain directory named "news" we will not try to insert it with
>> `insert-file-contents'.
>
> I agree that `file-regular-p' is sensible, what I meant was using
> `file-readable-p' in addition to that.  But I guess that all in all,
> this is a rare circumstance...

Oh, right.  Makes sense.  I've updated the patch.

0001-Insert-news-for-installed-packages-only.patch
Description: Text Data