[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-nam
From: |
Eli Zaretskii |
Subject: |
bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly |
Date: |
Tue, 29 Nov 2022 16:30:09 +0200 |
> Date: Tue, 29 Nov 2022 14:58:59 +0100
> Cc: jostein@kjonigsen.net, 59660@debbugs.gnu.org, theo@thornhill.no
> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
>
> > This could be a personal preference, perhaps? It isn't clear to me that
> > only one of the two is definitely correct. So maybe we need a user option
> > for which one overrides which?
>
> I honestly think this is reasonably clear.
>
> "Properties" with getters and setters are at this point in time almost
> entirely unused in EcmaScript/TypeScript space. They are optional and
> have complicated syntax, and don't play well with JSON serialization
> (and thus can't be used in REST APIs).
So you are saying Typescript should not even support these features in the
tree-sitter based fontifications? If so, I'm okay with that, but it sounds
like :override is the wrong tool for that, and we should simply remove
"properties" from the list of features for Typescript?
- bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification, (continued)
bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly, Yuan Fu, 2022/11/28