[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry
From: |
Manuel Giraud |
Subject: |
bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry |
Date: |
Thu, 24 Nov 2022 14:49:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
[...]
> Why do you think row->visible_height plays any role in this? Maybe I'm
> missing something, but it looks like it has nothing to do with the
> non-resizing of the menu bar.
Yes. I think that I was misled by the name.
[...]
> What I think we need to do is something like this:
>
> /* Compute the total height of the lines. */
> compute_line_metrics (&it);
> if (FRAME_WINDOW_P (it.f))
> {
> struct glyph_row *row = it.glyph_row;
> if (row->y + row->height > WINDOW_BOX_HEIGHT_NO_MODE_LINE (w))
> {
> FRAME_MENU_BAR_HEIGHT (it.f) = it.row->height;
> it.f->fonts_changed = true;
> }
> }
>
> I hope that setting the frame's fonts_changed flag will cause Emacs resize
> the menu-bar window. You should see a call to adjust_frame_glyphs from
> redisplay_internal; if that doesn't happen, perhaps we should force such a
> call right after display_menu_bar returns. Can you try this?
Ok. I'll try this and report. Thanks.
--
Manuel Giraud
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, (continued)
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/18
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/18
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/18
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/21
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/21
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/21
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/21
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Po Lu, 2022/11/21
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/23
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/23
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry,
Manuel Giraud <=
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/25
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/25
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/26
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/26
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/26
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Po Lu, 2022/11/26
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Eli Zaretskii, 2022/11/27
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/28
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Po Lu, 2022/11/28
- bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry, Manuel Giraud, 2022/11/29