[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59311: 29.0.50; tab-bar global-mode-string affected by global-displa
From: |
Juri Linkov |
Subject: |
bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers |
Date: |
Sun, 20 Nov 2022 20:02:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> I still don't understand why string-pixel-width should handle line-numbers
>> that also degrades its performance.
>
> Because string-pixel-width uses a temporary buffer as its internal
> implementation detail. (And why do you think this degrades performance? any
> measurements?)
Any additional code makes it slower. How much slower is a separate question.
>> I think it should be sufficient only
>> to disable line-numbers in internal buffers.
>
> I think it's too late for that, since display-line-numbers-mode is with us
> for the last 2 major releases.
Leaving it as is means waiting for more trouble in other places.
>> @@ -324,7 +324,8 @@ string-pixel-width
>> (with-current-buffer (get-buffer-create " *string-pixel-width*")
>> (delete-region (point-min) (point-max))
>> (insert string)
>> - (car (buffer-text-pixel-size nil nil t)))))
>> + (- (car (buffer-text-pixel-size nil nil t))
>> + (line-number-display-width t)))))
>
> This is fine by me. (Or you could turn off display-line-numbers-mode
> instead, right after with-current-buffer.)
Ok, fixed with the latter, and closed.
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Gabriel, 2022/11/16
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Juri Linkov, 2022/11/18
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Eli Zaretskii, 2022/11/18
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Juri Linkov, 2022/11/19
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Eli Zaretskii, 2022/11/19
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Juri Linkov, 2022/11/20
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers, Eli Zaretskii, 2022/11/20
- bug#59311: 29.0.50; tab-bar global-mode-string affected by global-display-line-numbers,
Juri Linkov <=