[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error
From: |
Eli Zaretskii |
Subject: |
bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error |
Date: |
Sun, 20 Nov 2022 12:17:54 +0200 |
> From: Gabriel <gabriel376@hotmail.com>
> Date: Wed, 16 Nov 2022 22:15:40 -0300
>
> Currently, Bookmark does not support relocate (bookmark-relocate) for
> Types that do not have a filename (e.g.: Eshell, EWW, Man etc). We
> still need to figure out a good way to let Bookmark Types to provide
> their own implementation (suggestions are welcome). While we don't
> teach Bookmark to provide such feature, it should handle these cases and
> provide an useful error message for users. See discussion [1].
>
> Steps:
>
> 1) emacs -Q (master f793add1758fd01f678698a90f5847b575f63cf8)
>
> 2) Run Eshell: M-x eshell RET
>
> 3) Add Eshell to Bookmark list: C-x r m RET
>
> 4) Open Bookmark list: C-x r l
>
> 5) Try to relocate the Eshell bookmark: R
>
> Result: bookmark-relocate: Wrong type argument: stringp, nil
>
> Patch:
>
> A remediation patch is attached.
Thanks, installed, and closing the bug.