|
From: | Paul Eggert |
Subject: | bug#58919: 28.2; dired-copy-file-recursive fails to overwrite directory |
Date: | Tue, 1 Nov 2022 11:04:22 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 |
On 2022-10-31 06:01, Eli Zaretskii wrote:
Paul, could you please look into this?
I am taking a look. Sigh, what a mess this code is; even the proposed fix has a TOCTOU bug.
The simplest fix I can see is to enhance make-directory so that it returns t if the directory already existed and PARENTS was given, nil on any other successful return. This would require changes to Tramp to avoid races there. I plan to post a proposed patch for comment.
[Prev in Thread] | Current Thread | [Next in Thread] |