[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#57639: [PATCH] Add new command 'toggle-theme'
From: |
Philip Kaludercic |
Subject: |
bug#57639: [PATCH] Add new command 'toggle-theme' |
Date: |
Sun, 11 Sep 2022 18:47:40 +0000 |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> Code exists for both Windows and Macos in the bug tracker somewhere, but
>>> haven't been integrated yet because nobody has sat down to make a
>>> consistent interface across all the platforms.
>>
>> What about GNU/Linux desktops?
>
> I thought we already had support for this under Gtk? But I may be
> misremembering.
Am I reading it correctly that `style_changed_cb' in gtkutils.c would be
a place to start looking for this functionality?
>> Stefans Gruvbox example had multiple dark and light variants. E.g.
>> Would the new command toggle from `gruvbox-dark-soft' to
>> `gruvbox-dark-light' or prompt the user to select from all the gruvbox
>> themes?
>
> Yes, but if you have the soft gruvbox active, you don't want to switch
> to the hard one when changing between dark/light, so there's no ambiguity.
So would gruvbox-soft-dark have all the other themes as variants or only
gruvbox-soft-dark?
>>> But now I see that you've pushed `toggle-theme'... *sigh*
>>
>> I'm very sorry about that, I've reverted those commits, since they were
>> accidentally pushed!
>
> *phew* Thanks. 😀
Here is an updated version:
0001-Add-new-command-theme-choose-variant.patch
Description: Text Data
- bug#57639: [PATCH] Add new command 'toggle-theme', (continued)
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/07
- bug#57639: [PATCH] Add new command 'toggle-theme', Philip Kaludercic, 2022/09/07
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/08
- bug#57639: [PATCH] Add new command 'toggle-theme', Philip Kaludercic, 2022/09/11
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/11
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/11
- bug#57639: [PATCH] Add new command 'toggle-theme', Philip Kaludercic, 2022/09/11
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/11
- bug#57639: [PATCH] Add new command 'toggle-theme',
Philip Kaludercic <=
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Philip Kaludercic, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Po Lu, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Michael Albinus, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Po Lu, 2022/09/13
- bug#57639: [PATCH] Add new command 'toggle-theme', Philip Kaludercic, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Po Lu, 2022/09/12
- bug#57639: [PATCH] Add new command 'toggle-theme', Lars Ingebrigtsen, 2022/09/13
- bug#57639: [PATCH] Add new command 'toggle-theme', Philip Kaludercic, 2022/09/14