[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro
From: |
Stefan Monnier |
Subject: |
bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro |
Date: |
Sun, 04 Sep 2022 12:44:24 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Michael Albinus [2022-09-04 16:53:27] wrote:
> Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
>> Pushed to `master`. This should fix this bug, which means we may want
>> to update the comment:
>>
>> ;; The basic structure for remote file names. We must autoload it in
>> ;; tramp-loaddefs.el, because some functions, which need it, wouldn't
>> ;; work otherwise when unloading / reloading Tramp. (Bug#50869)
>>
>> to clarify that it's now still kept in `tramp-loaddefs` but for
>> other reasons.
>
> Somehow, I don't understand the compiler machinery. Hmm.
In `master`, the unload problem described in bug#50869 has been fixed.
So the above comment suggests that we could remove the
`;;;###tramp-autoload` cookie in front of the `cl-defstruct`, but if you
do that, you get into other problems because the current Tramp code puts
other thins in `tramp-loaddefs.el` which also require this
`cl-defstruct` to be evaluated first.
> What comment you'd like to use instead? Remember, Tramp is backward
> compatible down to Emacs 26.
Something like
;; The basic structure for remote file names.
;; Note: We started autoloading it in tramp-loaddefs.el, because some
;; functions, which needed it, wouldn't work otherwise when unloading
;; / reloading Tramp (Bug#50869).
;; This bug is fixed in Emacs-29, but other parts of Tramp have grown
;; dependencies on having this in `tramp-loaddefs.el` in the mean time,
;; so .... here we are.
?
-- Stefan