[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilat
From: |
Eli Zaretskii |
Subject: |
bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation |
Date: |
Fri, 22 Jul 2022 16:40:14 +0300 |
> Cc: michael_heerdegen@web.de, 56643@debbugs.gnu.org, akrl@sdf.org
> Date: Thu, 21 Jul 2022 15:33:52 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > > > Alternatively we could introduce a named helper function. Note there
> > > > are more calls of `help-setup-xref' using lambdas in arguments.
> > >
> > >
> > > And that would solve the problem? Did you try that?
> >
> > I tried it with describe-function and it does solve the problem, although
> > as noted above there are many other functions that generate help buffers
> > and pass in a lambda.
>
> I know very well there are other instances, I just wanted us to stay
> focused.
>
> > Named helper:
> >
> > (defun describe-function-xref-func (function buffer)
> > (let ((describe-function-orig-buffer
> > (if (buffer-live-p buffer) buffer)))
> > (describe-function function)))
> >
> > Revised describe-function snippet:
> >
> > (help-setup-xref
> > (list 'describe-function-xref-func function
> > describe-function-orig-buffer)
> > (called-interactively-p 'interactive))
> >
> > This produces the following bookmark, which I confirmed still works after
> > restarting Emacs:
> >
> > ("named-function-help-bookmark"
> > (position . 1)
> > (last-modified 25305 7198 806743 243000)
> > (help-fn . describe-function-xref-func)
> > (help-args completing-read "*scratch*")
> > (position . 1)
> > (handler . help-bookmark-jump))
>
> Thanks. If Andrea confirms that this won't have any problems with
> native-compilation, I will install such changes on the release branch
> (since AFAIU this issue is a regression in Emacs 28).
Andrea, could you please tell if using a named function there will fix
the problem?
Thanks.
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, (continued)
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, defun . foo, 2022/07/19
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Andrea Corallo, 2022/07/20
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Andrea Corallo, 2022/07/20
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Eli Zaretskii, 2022/07/20
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Andrea Corallo, 2022/07/20
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Eli Zaretskii, 2022/07/20
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Michael Heerdegen, 2022/07/20
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Eli Zaretskii, 2022/07/21
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, defun . foo, 2022/07/21
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Eli Zaretskii, 2022/07/21
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation,
Eli Zaretskii <=
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Andrea Corallo, 2022/07/22
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Eli Zaretskii, 2022/07/22
- bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation, Eli Zaretskii, 2022/07/23