[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55676: [PATCH] non-recursive Lisp reader
From: |
Po Lu |
Subject: |
bug#55676: [PATCH] non-recursive Lisp reader |
Date: |
Sun, 29 May 2022 09:15:11 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks. One minor nit: you seem to have customized indentation in C
> source files in a way that is different from our conventions. Please
> reformat using our defaults (which use a mix of TABs and SPACEs).
Another minor nit:
>> + read_stack_push ((struct read_stack_entry){
>> + .type = RE_record,
>> + .u.vector.elems = Qnil,
>> + .u.vector.old_locate_syms = locate_syms,
>> + });
>> + locate_syms = false;
>> + goto read_obj;
There should at least be a space between the cast and the opening brace
of the compound literal, right? That applies to the rest of the printer
code you installed lately.
And I think using compound literals in `read_stack_push' (and
`print_stack_push') is very ugly, but there's no rule against it.
Thanks.