[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55386: 29.0.50; check-declare-directory doesn't work on Windows
From: |
Lars Ingebrigtsen |
Subject: |
bug#55386: 29.0.50; check-declare-directory doesn't work on Windows |
Date: |
Sat, 14 May 2022 13:40:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> How about the below? It's 3% to 9% slower than the find/grep version
> (because it examines more files, I think), but much simpler (IMNSHO),
> and works on any platform without any caveats.
[...]
> - (let ((files (process-lines-ignore-status
> - find-program root
> - "-name" "*.el"
> - "-exec" grep-program
> - "-l" "^[ \t]*(declare-function" "{}" "+")))
> + (let ((files (directory-files-recursively root "\\.el\\'")))
> (when files
> (apply #'check-declare-files files))))
I'm surprised that it's just 9% slower -- there's 2K files in the Emacs
tree, and only one a quarter of them have a declare-function. Is
process-lines-ignore-status really slow or something?
But the change looks fine to me in any case.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Yasuhiro Kimura, 2022/05/12
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Lars Ingebrigtsen, 2022/05/12
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/12
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Lars Ingebrigtsen, 2022/05/13
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/13
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Lars Ingebrigtsen, 2022/05/13
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows,
Lars Ingebrigtsen <=
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Lars Ingebrigtsen, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Po Lu, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Lars Ingebrigtsen, 2022/05/14
- bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Eli Zaretskii, 2022/05/14
bug#55386: 29.0.50; check-declare-directory doesn't work on Windows, Yasuhiro Kimura, 2022/05/12