[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55169: Can't combine window-min-height with window-height
From: |
Juri Linkov |
Subject: |
bug#55169: Can't combine window-min-height with window-height |
Date: |
Fri, 13 May 2022 19:58:40 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> Adding an alist is a good idea, but unfortunately it's not
>> backwards-compatible.
>
> That's what I'm trying to bring up ever since we started this thread.
> AFAICT we'd need two new functions at least - an action function say
> 'display-buffer-split-window'
Can the existing 'display-buffer-in-direction' be used to split window?
Or a new action 'display-buffer-split-in-direction' is needed?
> and a 'dislay-buffer-fit-window' function
> - both accepting the ALIST as (additional) argument.
But they can't be used simultaneously? When 'display-buffer-split-window'
splits the window, then the next 'dislay-buffer-fit-window' is not called?
>>> Think of an application suggesting 'fit-window-to-buffer' with some
>>> 'window-min-height' value and a user who wants to use
>>> 'shrink-window-if-larger-than-buffer' instead but still use the
>>> 'window-min-height' value proposed by the application. How would we do
>>> that?
>>
>> I have no idea how to make this backwards-compatible.
>
> It can be done with global variables but the resulting code will be
> neither elegant nor comprehensible. IMO any such information must be
> inevitably passed on through the ALIST argument.
Maybe a new alist key could be added, e.g. 'window-fit',
that is like 'window-height' but also adds the new arg 'alist'?
>> Definitively the functions that create a new window
>> should take into account height constraints.
>> But not sure about functions that select the existing window.
>> Should they resize the existing window?
>
> They do so already. With emacs -Q do
>
> (pop-to-buffer (get-buffer-create "*edit string*")
> '(display-buffer-below-selected
> (window-height . (lambda (window)
> (fit-window-to-buffer window nil 10)))))
>
> followed by
>
> (pop-to-buffer (get-buffer-create "*edit string*")
> '(display-buffer-below-selected
> (window-height . (lambda (window)
> (fit-window-to-buffer window nil 20)))))
Nice!
- bug#55169: Can't combine window-min-height with window-height, (continued)
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/07
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/08
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/09
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/09
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/09
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/10
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/11
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/11
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/12
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/13
- bug#55169: Can't combine window-min-height with window-height,
Juri Linkov <=
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/14
- bug#55169: Can't combine window-min-height with window-height, Richard Stallman, 2022/05/11
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/12
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/18
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/19
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/19