[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55169: Can't combine window-min-height with window-height
From: |
Juri Linkov |
Subject: |
bug#55169: Can't combine window-min-height with window-height |
Date: |
Fri, 06 May 2022 10:52:44 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> Because it should be the task of fit-window-to-buffer,
>> and it already has the argument MIN-HEIGHT.
>> Also other arguments of fit-window-to-buffer
>> could be allowed to use in display-buffer-alist.
>
> You mean the value of a 'window-height' entry could also be a
>
> • A list whose CAR is a function and whose remaining elements
> are the arguments passed to that function.
>
> so we'd run
>
> (ignore-errors (funcall (car height) window (nth 1 height) ...))
>
> in 'window--display-buffer'? Which means the caller has to know the
> function and which arguments it needs in which order. Sounds fragile.
It is intended only for special handling of 'fit-window-to-buffer'.
If 'fit-window-to-buffer' with MIN-HEIGHT will really fix this problem,
then details of the entry format could be adapted later.
And indeed this works exactly as should with
(pop-to-buffer (generate-new-buffer "*edit string*")
'(display-buffer-below-selected
(window-height . fit-window-to-buffer)))
and an experimental patch:
diff --git a/lisp/window.el b/lisp/window.el
index 9f78784612..a21cf109a4 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7336,7 +7336,9 @@ window--display-buffer
(window-resize window delta nil 'safe t)))
(setq resize-temp-buffer-window-inhibit 'vertical))
((functionp height)
- (ignore-errors (funcall height window))
+ (if (eq height 'fit-window-to-buffer)
+ (ignore-errors (funcall height window nil 10))
+ (ignore-errors (funcall height window)))
(setq resize-temp-buffer-window-inhibit 'vertical)))
;; Adjust width of window if asked for.
(cond
- bug#55169: Can't combine window-min-height with window-height, (continued)
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/02
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/03
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/03
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/04
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/04
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/05
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/05
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/05
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/05
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/06
- bug#55169: Can't combine window-min-height with window-height,
Juri Linkov <=
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/06
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/06
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/07
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/08
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/09
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/09
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/09
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/10
- bug#55169: Can't combine window-min-height with window-height, Juri Linkov, 2022/05/11
- bug#55169: Can't combine window-min-height with window-height, martin rudalics, 2022/05/11