[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#55205: 28.1.50; completion--replace illegally mutates completion can
From: |
Stefan Monnier |
Subject: |
bug#55205: 28.1.50; completion--replace illegally mutates completion candidates |
Date: |
Mon, 02 May 2022 02:31:05 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
> I've got an imdb interface where I choose among different movies (some
> with the same name) by putting the movie poster in the completion
> string to disambiguate. That's the first place I ran into the problem,
> years ago (and it seems like people keep trying to do things like that,
> and then giving up).
I'm a strong proponent of "different completions should be selectable by
different strings", for the kinds of reasons exposed by Daniel: it makes
it possible to use more UI styles than just selection (and it interacts
better with other things like elimination of duplicates).
But FWIW, that is not a reason to force throwing away the text
properties (IOW the act of stripping the text properties is not
a feature of the code).
E.g. I'd recommend you always include the movie's unique ID in the
completions, probably covered/hidden by the movie's poster (so the ugly
ID doesn't show up). And when the user selects that entry it would make
a lot of sense to keep displaying the poster.
> If I remember correctly, I ended up copying most of the completion
> machinery into the package just to avoid the stripping.
We should fix the code so it's not necessary.
Stefan
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, (continued)
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Daniel Mendler, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Daniel Mendler, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Dmitry Gutov, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Dmitry Gutov, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/01
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates,
Stefan Monnier <=
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/02
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Daniel Mendler, 2022/05/02
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Stefan Monnier, 2022/05/02
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/03
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Stefan Monnier, 2022/05/03
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/04
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Daniel Mendler, 2022/05/04
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Daniel Mendler, 2022/05/04
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Daniel Mendler, 2022/05/02
- bug#55205: 28.1.50; completion--replace illegally mutates completion candidates, Lars Ingebrigtsen, 2022/05/02