[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgt
From: |
Po Lu |
Subject: |
bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds |
Date: |
Fri, 01 Apr 2022 10:00:10 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Pieter van Prooijen <pieter.van.prooijen@teloden.nl> writes:
> Hi All,
>
> Thanks for the review, I've updated the commit message and other
> changes you mentioned in the attached patch (against
> c5af19cba5924de89a38e7a177c07f42fd3cd543)
>
> I've requested the form for the copyright assignment, but have not
> received it yet, will send it in as soon as it arrives.
>
> No progress yet on the problem with subpixel antialiasing, but it
> doesn't look like a fontconfig issue, as a non-pgtk build from the same
> source works correctly, will have to dig deeper to find out what is
> happening.
Thanks.
>> > + on the result. */
Hmm... Is there an actual non-breaking space character here, or is your
MUA munging the messages?
> + if (dpyinfo_valid (first_dpyinfo))
> + store_config_changed_event (Qfont_render,
> + XCAR (first_dpyinfo->name_list_element));
You got the indentation wrong here. The "s" in
"store_config_changed_event" should be two spaces behind where it is
now.
Otherwise, LGTM. Hopefully the copyright paperwork can be finished soon.
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, (continued)
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, Eli Zaretskii, 2022/03/26
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, Pieter van Prooijen, 2022/03/26
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, Po Lu, 2022/03/26
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, Pieter van Prooijen, 2022/03/30
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, Po Lu, 2022/03/30
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds, Pieter van Prooijen, 2022/03/31
- bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds,
Po Lu <=