[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe i
From: |
Lars Ingebrigtsen |
Subject: |
bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken |
Date: |
Wed, 23 Feb 2022 13:14:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Jim Porter <jporterbugs@gmail.com> writes:
>> Thanks, this fixes the test. However, I'm unsure we should fix this
>> inside eshell-sentinel: do we always want to ignore "broken pipe"
>> errors in Eshell subprocesses, and never show them to the user?
>
> I think we do want to ignore that error here. In `eshell-sentinel', we
> only run the `finish-io' code when the subprocess's state has already
> changed; in this case, that means the subprocess has already been
> terminated, since Eshell doesn't handle cases like SIGSTOP or SIGCONT
> yet (see the commented out functions at the bottom of
> lisp/eshell/esh-proc.el). Normally, if we detect a broken pipe, we'd
> want to signal the subprocess that tried to write, but since we know
> it's already been terminated, there's no (living) process to signal
> anymore.
Makes sense to me, I think, so I pushed the patch to Emacs 29.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, (continued)
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Eli Zaretskii, 2022/02/19
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Jim Porter, 2022/02/19
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Eli Zaretskii, 2022/02/20
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Jim Porter, 2022/02/20
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Eli Zaretskii, 2022/02/21
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Lars Ingebrigtsen, 2022/02/21
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Eli Zaretskii, 2022/02/21
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Jim Porter, 2022/02/21
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Eli Zaretskii, 2022/02/22
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Jim Porter, 2022/02/22
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken,
Lars Ingebrigtsen <=
- bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken, Jim Porter, 2022/02/24