[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54025: 27.2; dired-do-find-regexp skips occurences
From: |
Петров Андрей |
Subject: |
bug#54025: 27.2; dired-do-find-regexp skips occurences |
Date: |
Wed, 23 Feb 2022 07:01:09 +0000 |
Dmitry,
Looks great!
RecentlyI found a function `dired-do-search' which uses searching in buffers
(and sees unsaved occurences). It seems that processing unmodified (or not
open) files with grep and modified ones with searching in buffers would be a
well-balanced approach saving both memory and possible network traffic (or SSD
rewrite cycles) but this is rather feature to make in the future then a hot fix
)).
People who expect searching in modified buffers still can use `dired-do-search'
and `dired-do-query-replace-regexp' which may work slower.
So I think the current decision is OK.
Best regards,
Andrey Petrov.
________________________________________
От: DG <raaahh@gmail.com> от имени Dmitry Gutov <dgutov@yandex.ru>
Отправлено: 23 февраля 2022 г. 7:38:17
Кому: Петров Андрей; Eli Zaretskii
Копия: 54025@debbugs.gnu.org
Тема: Re: bug#54025: 27.2; dired-do-find-regexp skips occurences
On 21.02.2022 09:00, Петров Андрей wrote:
> I think it is convenient to ask user to save some buffers (like `rgrep' do)
> if the search algorithm implementation requires all files to be saved.
> Optionally modified buffers can be skipped with appropriate logging into
> messages buffer.
How about this?
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 56897826cb..16094f4551 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -3272,6 +3272,7 @@ dired-do-find-regexp
(require 'xref)
(defvar grep-find-ignored-files)
(declare-function rgrep-find-ignored-directories "grep" (dir))
+ (save-some-buffers)
(let* ((marks (dired-get-marked-files nil nil nil nil t))
(ignores (nconc (mapcar
#'file-name-as-directory
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 880c5b5517..f772871f72 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -834,6 +834,7 @@ project-or-external-find-regexp
nil)))
(defun project--find-regexp-in-files (regexp files)
+ (save-some-buffers)
(unless files
(user-error "Empty file list"))
(let ((xrefs (xref-matches-in-files regexp files)))
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index aa98aa89f1..ae19632974 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -273,6 +273,7 @@ xref-backend-references
The default implementation uses `semantic-symref-tool-alist' to
find a search tool; by default, this uses \"find | grep\" in the
current project's main and external roots."
+ (save-some-buffers)
(mapcan
(lambda (dir)
(message "Searching %s..." dir)
@@ -2013,7 +2014,9 @@ xref--find-file-buffer
(setq xref--last-file-buffer
;; `find-buffer-visiting' is considerably slower,
;; especially on remote files.
- (cons file (get-file-buffer file))))
+ (cons file (get-file-buffer file)))
+ (when (buffer-modified-p (cdr xref--last-file-buffer))
+ (message "Buffer %s has unsaved changes" (cdr
xref--last-file-buffer))))
(cdr xref--last-file-buffer))
(provide 'xref)
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Петров Андрей, 2022/02/16
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/20
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Eli Zaretskii, 2022/02/20
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Петров Андрей, 2022/02/21
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/21
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/22
- bug#54025: 27.2; dired-do-find-regexp skips occurences,
Петров Андрей <=
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/23
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Петров Андрей, 2022/02/24
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/24
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Michael Albinus, 2022/02/25
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/25
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Michael Albinus, 2022/02/25
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/25
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Michael Albinus, 2022/02/26
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Петров Андрей, 2022/02/26
- bug#54025: 27.2; dired-do-find-regexp skips occurences, Dmitry Gutov, 2022/02/26