[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53817: 28.0.91; sh-mode indent misses on 'if test; then' when 'then'
From: |
Lars Ingebrigtsen |
Subject: |
bug#53817: 28.0.91; sh-mode indent misses on 'if test; then' when 'then' is on 'if' line |
Date: |
Mon, 07 Feb 2022 00:50:49 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Doug Maxey <emacs-bugs@maxeygroup.tech> writes:
> However, lots'o bash gets written here, and one of my idioms is:
> <code>
> if test;then
> do something
> fi
> ^
> </code>
The problem seems to be here:
(defun sh-smie--default-backward-token ()
[...]
(progn (skip-syntax-backward ".w_'")
(or (not (zerop (skip-syntax-backward "\\")))
(when (eq ?\\ (char-before (1- (point))))
Semi-colons have punctuation syntax, so we're skipping back over the
entirety of "test;then" instead of stopping after "then".
This looks easy enough to fix, but the overall logic of that function is
somewhat obscure to me, so I've added Stefan to the comments; perhaps he
has some comments.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no