bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell


From: Jim Porter
Subject: bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell
Date: Wed, 2 Feb 2022 11:41:33 -0800

On 2/2/2022 10:10 AM, Lars Ingebrigtsen wrote:
These patches seem to lead to a number of tests failing:

Test eshell-test/last-result-var2 condition:
     (void-variable eshell-last-async-proc)
    FAILED  22/34  eshell-test/last-result-var2 (0.001074 sec) at 
lisp/eshell/eshell-tests.el:164
    passed  23/34  eshell-test/lisp-command (0.000350 sec)
    passed  24/34  eshell-test/lisp-command-args (0.000308 sec)

Sorry, I forgot to mention that since the second patch updates a defsubst (`eshell-interactive-process'), you'll need to recompile all the files that might use it, so `make boostrap' or `touch lisp/eshell/*.el test/lisp/eshell/*.el && make'. That should make these tests pass.

Once this merges, I'll send a message to emacs-devel to let everyone know to recompile these files so there are no surprises when they try to use Eshell later on.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]