[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52839: 29.0.50; The '(declare (modes MODE...))' NEWS entry is confus
From: |
Stefan Monnier |
Subject: |
bug#52839: 29.0.50; The '(declare (modes MODE...))' NEWS entry is confusing |
Date: |
Tue, 28 Dec 2021 15:27:38 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
> Apart from changing the default value, that is.
That seems to be asking a question: what is the reason for the current
default value. AFAICT this comes from:
commit 927b88571cebb4f64aca360fbfa5d15a1f922ad6
Author: Eli Zaretskii <eliz@gnu.org>
Date: Wed Feb 17 18:53:54 2021 +0200
Disable filtering of commands in M-x completion
This makes the default behavior like it was before:
M-x completion doesn't filter out any commands. To
have commands filtered based on their relevance to the
current buffer's modes, customize the option
'read-extended-command-predicate' to call
'command-completion-default-include-p'.
* doc/lispref/commands.texi (Interactive Call):
* doc/emacs/m-x.texi (M-x): Update the description of
'read-extended-command-predicate' and improve wording.
* etc/NEWS: Update the entry about
'read-extended-command-predicate'.
* lisp/simple.el (read-extended-command-predicate): Change default
value to nil. Update doc string. Add :group.
(read-extended-command): Handle nil as meaning to apply
no-filtering.
But the commit doesn't say why this change was made (other than saying
"like it was before"). Was there a specific problem introduced by the
filtering, or was it a change based on a judgment call about what the
default should be to balance the tradeoffs between bringing new
features and surprising the users?
Stefan "who doesn't have an opinion on this one"
bug#52839: 29.0.50; The '(declare (modes MODE...))' NEWS entry is confusing, Eli Zaretskii, 2021/12/29