[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51451: image-transform-original has a misleading name
From: |
Stefan Kangas |
Subject: |
bug#51451: image-transform-original has a misleading name |
Date: |
Wed, 3 Nov 2021 13:16:55 -0700 |
Juri Linkov <juri@linkov.net> writes:
>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should. Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables.
That's true.
> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.
I see a problem with all of them, especially in combination with
`image-save'. :-(
But the most confusing one by far is `image-transform-original', indeed.