[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50630: [PATCH] Add tests for insert-directory
From: |
John Cummings |
Subject: |
bug#50630: [PATCH] Add tests for insert-directory |
Date: |
Sat, 25 Sep 2021 12:30:51 +0000 |
John Cummings <john@rootabega.net> wrote:
> Eli Zaretskii eliz@gnu.org wrote:
> > > Date: Fri, 24 Sep 2021 19:58:25 +0000
> > > From: John Cummings john@rootabega.net
> > > Along those lines, I also attempted to skip the test when ls-lisp
> > > would be used during files-tests.el, which I predict might happen when
> > > building on Windows?
> > Why did you need to skip those tests? Can you elaborate?
> ls-lisp has its own implementation of insert-directory, which
[snipped long section about WHY I thought the test should be skipped]
Also, I now see how making files-tests.el responsible for
accommodating ls-lisp.el might be backwards. If skipping the tests is
still a good idea, I'll try to learn if there's a more conventional
way to do it, e.g. having files-tests.el look for more general signs
that the insert-directory implementation has been overridden, or
maybe having ls-lisp.el be responsible for asking that that test be
skipped.
- bug#50630: [External] : bug#50630: 28.0.50; list-directory shows free space for current directory, not the specified one, (continued)
bug#50630: Confirmation of instances in ls-lisp.el and tramp-sh.el, John Cummings, 2021/09/21
bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/24
bug#50630: [PATCH] Add tests for insert-directory, Eli Zaretskii, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory,
John Cummings <=
- bug#50630: [PATCH] Add tests for insert-directory, Eli Zaretskii, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, Eli Zaretskii, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, Eli Zaretskii, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, Eli Zaretskii, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, Eli Zaretskii, 2021/09/25
- bug#50630: [PATCH] Add tests for insert-directory, John Cummings, 2021/09/25