[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50667: Update ecomplete when used via standard UI
From: |
Augusto Stoffel |
Subject: |
bug#50667: Update ecomplete when used via standard UI |
Date: |
Sat, 18 Sep 2021 23:35:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On Sat, 18 Sep 2021 at 23:06, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Augusto Stoffel <arstoffel@gmail.com> writes:
>
>> If one keeps sets
>>
>> (setq message-mail-alias-type nil ;; or keep the default 'abbrev
>> message-expand-name-standard-ui t)
>>
>> and an ecomplete database file, then everything works OOTB,
>
> Works in what way?
If I hit TAB in an address field, my completion UI kicks in and I can
choose an address from the ecomplete database.
>
>> except that the ecomplete database doesn't get updated with new
>> addresses.
>>
>> Is the following change a reasonable fix for this?
>
> [...]
>
>> - (when (and (message-mail-alias-type-p 'ecomplete)
>> + (when (and (bound-and-true-p ecomplete-database)
>
> I think this would be highly surprising behaviour -- just loading a
> library shouldn't have such side effects.
Loading ecomplete doesn't populate 'ecomplete-database'. But if you set
'message-expand-name-standard-ui' to t, then 'ecomplete-start' will be
called when request completions.
>
> What's your use case here? You don't want to use ecomplete for alias
> expansions, but you still want to update the ecomplete database?
I want to use ecomplete via completion at point instead of ecomplete's
electric UI. This is what the variable
'message-expand-name-standard-ui' is meant for, right?