[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled o
From: |
Alan Third |
Subject: |
bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS |
Date: |
Sun, 12 Sep 2021 12:48:28 +0100 |
On Sun, Sep 12, 2021 at 02:29:19AM +0200, Kirill A. Korinsky via Bug reports
for GNU Emacs, the Swiss army knife of text editors wrote:
> Good day!
>
> I've described this bug here:
> https://github.com/hlissner/doom-emacs/issues/5469
>
> During investigation I've discovered the exact commit which brokes
> toolbar on this scenario.
>
> Let me share git bisect log:
> git bisect start
> # good: [cfcf42ff879f766ffe5812fb0cd12f35803c1bfb] Ensure that gud commands
> for non-GDB debuggers are handled by repeat-mode
> git bisect good cfcf42ff879f766ffe5812fb0cd12f35803c1bfb
> # bad: [192a384408cc846d8e66e91a67cd9ad4e7f0be24] Revert usage of
> format-prompt in python.el
> git bisect bad 192a384408cc846d8e66e91a67cd9ad4e7f0be24
> # bad: [beb54dc1b2b00cb4541b82acf6ead8a8075c3011] Improve documentation of
> 'file-preserve-symlinks-on-save'
> git bisect bad beb54dc1b2b00cb4541b82acf6ead8a8075c3011
> # bad: [c56e395edf5babdbcc65fa7bdb9fb462c674f156] Let
> image-dired-mouse-toggle-mark act on active region
> git bisect bad c56e395edf5babdbcc65fa7bdb9fb462c674f156
> # bad: [0ec67a295632f3c4ac92e0b6a0070f67dedac4eb] ; so-long-tests.el:
> Suppress expected warnings
> git bisect bad 0ec67a295632f3c4ac92e0b6a0070f67dedac4eb
> # bad: [12c5ca4d825496b3c7304b75ab82a6fabdc2023d] Fix some macOS problems
> git bisect bad 12c5ca4d825496b3c7304b75ab82a6fabdc2023d
> # good: [0bd1346318fe9ef4eba91905172d30a030d7da18] Fix issue with mml-preview
> from outside Gnus
> git bisect good 0bd1346318fe9ef4eba91905172d30a030d7da18
> # good: [55a9c17cef78b1fd3da42bcc2ab55d4acbaa24eb] Change Tramp version to
> "2.5.2-pre"
> git bisect good 55a9c17cef78b1fd3da42bcc2ab55d4acbaa24eb
> # good: [a4d2c88cdee90a3e4863a62c4ff69896d0c1a347] Simplify macOS drawing code
> git bisect good a4d2c88cdee90a3e4863a62c4ff69896d0c1a347
> # bad: [1ba02d85a964e1b2c6a9735cd3decdc524e06dc1] Fix macOS live resize
> drawing
> git bisect bad 1ba02d85a964e1b2c6a9735cd3decdc524e06dc1
> # bad: [960f3fc589d8d021e1ed1a505e660929e4c13d0a] Change NS port resize
> detection
> git bisect bad 960f3fc589d8d021e1ed1a505e660929e4c13d0a
> # good: [1535c81f77153dd61426246be2e8afd33fa6909a] Tidy up NS port OS window
> handling
> git bisect good 1535c81f77153dd61426246be2e8afd33fa6909a
> # first bad commit: [960f3fc589d8d021e1ed1a505e660929e4c13d0a] Change NS port
> resize detection
I can't for the life of my see why that commit should break it, but
can you please try the attached patch and see if it fixes the problem?
I can't replicate it here.
--
Alan Third
0001-Fix-incorrectly-appearing-toolbar-on-NS-bug-50534.patch
Description: Text Data
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Kirill A. Korinsky, 2021/09/11
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS,
Alan Third <=
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Kirill A. Korinsky, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Kirill A. Korinsky, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Alan Third, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Kirill A. Korinsky, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Alan Third, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Alan Third, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Kirill A. Korinsky, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Alan Third, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Kirill A. Korinsky, 2021/09/12
- bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS, Alan Third, 2021/09/13