[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32496: 27.0.50; Strange indentation when ruby-align-chained-calls is
From: |
Lars Ingebrigtsen |
Subject: |
bug#32496: 27.0.50; Strange indentation when ruby-align-chained-calls is t |
Date: |
Thu, 02 Sep 2021 08:55:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Bozhidar Batsov" <bozhidar@batsov.dev> writes:
> Ah, I finally understood the issue at hand! It's really hard to discuss
> indentation problems in e-mail. :D
>
> Yeah, I can confirm there's a bug when using (setq ruby-align-chained-calls t)
> in this example:
>
> some_variable.where.not(x: nil)
> .where(y: 2)
>
> The two `where`s should be lined up, but currently the second `where` is
> lined up with the `not`.
So this is coming from:
('(:before . ".")
(if (smie-rule-sibling-p)
(and ruby-align-chained-calls 0)
(smie-backward-sexp ".")
(cons 'column (+ (current-column)
ruby-indent-level))))
In the aligned case, I think we should back up to the first "." in the
chain and use that as the column? But my SMIE-fu is pretty much
non-existent, so I've added Stefan to the CCs.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no