[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color an
From: |
Eli Zaretskii |
Subject: |
bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode |
Date: |
Tue, 24 Aug 2021 20:59:40 +0300 |
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Tue, 24 Aug 2021 10:38:06 -0700
> Cc: 50179@debbugs.gnu.org
>
> > I wouldn't offer a customizable list for this: users have no
> > particular reason to redefine standard colors.
>
> I made this a defcustom because `ansi-color-faces-vector' and
> `ansi-color-names-vector' are defcustoms too. More practically
> speaking, I'd want to customize this new variable to make these colors
> match the Emacs theme I use. I chose colors in this patch to
> complement `ansi-color-names-vector', but they'd clash with my theme.
How can named colors change with the theme? Faces can, but colors are
absolute. Bright-yellow is the same color whatever the theme. At
least IMO. I wonder if others think otherwise.
> > > +(defcustom term-color-bold-is-bright nil
> > > + "If set to non-nil, combining ANSI bold and a color produces the bright
> > > +version of that color."
> > > + :group 'term
> > > + :type 'boolean
> > > + :version "28.1")
> >
> > Do we really need 2 separate knobs for these two features? How
> > probable is it that the same user will want to have bright colors in
> > one package, but not in the other?
>
> I doubt anyone would want to control these independently. It'd be nice
> to have a single defcustom for this, but I wasn't sure where it should
> go in that case.
If we agree to have a single defcustom, then where to put it is
secondary.
> Would it be ok to use `ansi-color-bold-is-bright'
> (from patch 1 in `ansi-color.el') in `term.el'?
Yes, why not?
Thanks.
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Jim Porter, 2021/08/24
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Eli Zaretskii, 2021/08/24
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Jim Porter, 2021/08/24
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode,
Eli Zaretskii <=
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Jim Porter, 2021/08/24
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Jim Porter, 2021/08/24
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Lars Ingebrigtsen, 2021/08/25
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Jim Porter, 2021/08/25
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Lars Ingebrigtsen, 2021/08/25
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Eli Zaretskii, 2021/08/25
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Lars Ingebrigtsen, 2021/08/26
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Kévin Le Gouguec, 2021/08/25
- bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode, Eli Zaretskii, 2021/08/25