[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48669: Inconsistent overlay placement between minibuffer-message and
From: |
Juri Linkov |
Subject: |
bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message |
Date: |
Tue, 08 Jun 2021 19:52:07 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
tags 48669 fixed
close 48669 28.0.50
thanks
>> >> - (let ((ol (make-overlay (point-max) (point-max) nil t t))
>> >> + (let* ((ovpos (minibuffer--message-overlay-pos))
>> >> + (ol (make-overlay ovpos ovpos nil t t))
>> >
>> > Doesn't this rely too much on the internal details of
>> > minibuffer--message-overlay-pos? At least, without any comments, this
>> > call looks like a riddle that isn't easy to unlock.
>>
>> If minibuffer--message-overlay-pos serves its purpose for
>> set-minibuffer-message, it seems suitable for
>> minibuffer-message as well.
>
> So you object to adding a comment there which would explain what that
> call does?
Now I added a comment, and pushed to master.
>> >> - (put-text-property 0 1 'cursor t message))
>> >> + (put-text-property 0 1 'cursor 1 message))
>> >
>> > Why this change?
>>
>> Only to make minibuffer-message the identical copy of
>> set-minibuffer-message.
>
> I'd say make it the other way around. Handling the 'cursor' property
> with a numeric value is more expensive and tricky than if the value is
> t, and in this case the effect is exactly the same.
So I changed the 'cursor' property to t.