[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48031: 28.0.50; comp-tests oddities
From: |
Andrea Corallo |
Subject: |
bug#48031: 28.0.50; comp-tests oddities |
Date: |
Mon, 26 Apr 2021 16:46:39 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Michael Albinus <michael.albinus@gmx.de> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> Hi Michael,
>
> Hi Andrea,
>
>> as of 9d34fd8b33 both issues should be solved, could you have a look if
>> it works for you too?
>
> LGTM.
>
> Btw, in ert-x.el we have the macros `ert-resource-directory' and
> `ert-resource-file'.
>
> (defconst comp-test-directory (concat (file-name-directory
> (or load-file-name
> buffer-file-name))
> "comp-tests-resources/"))
>
>
> could be
>
> (defconst comp-test-directory (ert-resource-directory)
>
>
> (or just be removed), and
>
> (defconst comp-test-src
> (expand-file-name "comp-test-funcs.el" comp-test-directory))
Nice!
In this case I guess we have to rename "test/src/comp-tests-resources/"
into "test/src/comp-resources/" would this be okay?
Thanks
Andrea