bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#45412: File ... is large (... MiB), really open? (y)es or (n)o or (l


From: Juri Linkov
Subject: bug#45412: File ... is large (... MiB), really open? (y)es or (n)o or (l)iterally
Date: Fri, 23 Apr 2021 01:09:04 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> The idea to show the help text also for graphical prompts is a good
> idea, but as there's no command already in Emacs that supports it,
> AFAIK, it could be a separate feature request.  What do you think?

Thanks.  While testing your patches, I noticed a compilation warning:

  emacs-lisp/rmc.el:29:1: Warning: Variable `buf' left uninitialized

Also these let-bindings are duplicated:

  (prompt (format "File %s is large (%s), really %s?"
                  (file-name-nondirectory filename)
                  (funcall byte-count-to-string-function size) op-type))

Otherwise, it looks nice, except of Eli's comment about the need
to keep graphical dialogs.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]