[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47215: 28.0.50; Let M-x switch between M-x and M-X
From: |
Lars Ingebrigtsen |
Subject: |
bug#47215: 28.0.50; Let M-x switch between M-x and M-X |
Date: |
Sun, 11 Apr 2021 19:36:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Felician Nemeth <felician.nemeth@gmail.com> writes:
> I've discovered that the initial-input argument of `completing-read` can
> be written as (STRING . POSITION). The attached patch makes use of it
> and shows a simple implementation of my original wish.
Nice; your patch works very smoothly -- using `M-x' to switch here feels
very natural.
> However, the patch creates code duplication.
I think that can be fixed by refactoring out most of the interactive
spec of `execute-extended-command-for-buffer' and then reusing it.
> Also, I don't know how it copes with recursive editing: maybe it's not
> a good idea to rebind M-x when `enable-recursive-minibuffers' is t.
A lot of people have `enable-recursive-minibuffers' bound, though, which
is an argument against using `M-x' as the keystroke to switch between
modes.
> Finally, the docstring says initial-input is deprecated.
I think this use case demonstrates that perhaps we should slightly
un-deprecate initial-input -- instead of deprecating it, we could
instead just discourage the usage.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no