[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38164: quit-restore-window doesn't restore point in man
From: |
Eli Zaretskii |
Subject: |
bug#38164: quit-restore-window doesn't restore point in man |
Date: |
Sun, 04 Apr 2021 21:28:38 +0300 |
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Sun, 04 Apr 2021 19:13:01 +0100
> Cc: 38164@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Juri Linkov <juri@linkov.net> writes:
> >
> >> - (quit-restore-window
> >> - (get-buffer-window Man-buffer t) 'kill)
> >> + (progn
> >> + (quit-restore-window
> >> + (get-buffer-window Man-buffer t) 'kill)
> >> + (select-window (old-selected-window)))
> >
> > The discussion then dealt mostly with general quit-restore-windows
> > issues, but I think this patch should be applied, since it fixes an
> > annoying problem in Man. So I've now pushed it to Emacs 28.
>
> This gives rise to the following regression:
>
> 0. emacs -Q
> 1. (setq Man-notify-method 'aggressive) C-x C-e
> 2. M-x man RET mythical RET
>
> This used to pop up and very quickly hide a window (but that's a
> separate issue), and then the echo area displayed:
>
> Can't find the mythical manpage
>
> Whereas now the phantom window remains displayed much longer, the echo
> area displays:
>
> error in process sentinel:
> Wrong type argument: window-live-p, #<window 8>
>
> and the *Messages* buffer also contains:
>
> error in process sentinel:
> Man-bgproc-sentinel: Wrong type argument: window-live-p, #<window 8>
So we traded a minor issue for a more serious one. (And if I try the
recipe which triggered that change, I see a perfectly expected
behavior in Emacs 24.)
I think that change should be reverted.