[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#46155: [PATCH v2] Fix flicker when resizing NS frame programmaticall
From: |
Alan Third |
Subject: |
bug#46155: [PATCH v2] Fix flicker when resizing NS frame programmatically (bug#46155) |
Date: |
Thu, 11 Feb 2021 22:16:48 +0000 |
; Incidentally fixes bug#21326.
* src/nsterm.m ([EmacsView viewWillDraw]): New function.
([EmacsView viewDidResize:]): We now have to mark the frame for
display on resize.
([EmacsView initFrameFromEmacs:]): Retain frame contents on resize.
([EmacsView updateLayer]): Don't update the layer is the frame is
still garbaged.
---
src/nsterm.m | 47 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/src/nsterm.m b/src/nsterm.m
index 1b2328628e..ab898184f5 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7339,6 +7339,8 @@ - (void)viewDidResize:(NSNotification *)notification
[surface release];
surface = nil;
+
+ [self setNeedsDisplay:YES];
}
#endif
@@ -7510,6 +7512,16 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f
[self initWithFrame: r];
[self setAutoresizingMask: NSViewWidthSizable | NSViewHeightSizable];
+#ifdef NS_DRAW_TO_BUFFER
+ /* These settings mean AppKit will retain the contents of the frame
+ on resize. Unfortunately it also means the frame will not be
+ automatically marked for display, but we can do that ourselves in
+ viewDidResize. */
+ [self setLayerContentsRedrawPolicy:
+ NSViewLayerContentsRedrawOnSetNeedsDisplay];
+ [self setLayerContentsPlacement:NSViewLayerContentsPlacementTopLeft];
+#endif
+
FRAME_NS_VIEW (f) = self;
emacsframe = f;
#ifdef NS_IMPL_COCOA
@@ -8452,6 +8464,34 @@ - (void)copyRect:(NSRect)srcRect to:(NSRect)dstRect
}
+#ifdef NS_IMPL_COCOA
+/* If the frame has been garbaged but the toolkit wants to draw, for
+ example when resizing the frame, we end up with a blank screen.
+ Sometimes this results in an unpleasant flicker, so try to
+ redisplay before drawing. */
+- (void)viewWillDraw
+{
+ if (FRAME_GARBAGED_P (emacsframe)
+ && !redisplaying_p)
+ {
+ /* If there is IO going on when redisplay is run here Emacs
+ crashes. I think it's because this code will always be run
+ within the run loop and for whatever reason processing input
+ is dangerous. This technique was stolen wholesale from
+ nsmenu.m and seems to work. */
+ bool owfi = waiting_for_input;
+ waiting_for_input = 0;
+ block_input ();
+
+ redisplay ();
+
+ unblock_input ();
+ waiting_for_input = owfi;
+ }
+}
+#endif
+
+
#ifdef NS_DRAW_TO_BUFFER
- (BOOL)wantsUpdateLayer
{
@@ -8469,6 +8509,13 @@ - (void)updateLayer
{
NSTRACE ("[EmacsView updateLayer]");
+ /* We run redisplay on frames that are garbaged but marked for
+ display before updateLayer is called, so if the frame is still
+ garbaged that means the last redisplay must have refused to
+ update the frame. */
+ if (FRAME_GARBAGED_P (emacsframe))
+ return;
+
/* This can fail to update the screen if the same surface is
provided twice in a row, even if its contents have changed.
There's a private method, -[CALayer setContentsChanged], that we
--
2.29.2
--
Alan Third
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, (continued)
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Andrii Kolomoiets, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, martin rudalics, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, martin rudalics, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Andrii Kolomoiets, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, martin rudalics, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Alan Third, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Alan Third, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Andrii Kolomoiets, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Alan Third, 2021/02/09
- bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when, Aaron Jensen, 2021/02/09
bug#46155: [PATCH v2] Fix flicker when resizing NS frame programmatically (bug#46155),
Alan Third <=