[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24651: 25.1; frame-inherited-parameters only partially works
From: |
martin rudalics |
Subject: |
bug#24651: 25.1; frame-inherited-parameters only partially works |
Date: |
Mon, 30 Nov 2020 18:30:29 +0100 |
> So it seems like something is going wrong when doing the inherited
> height parameter -- it's not initialising everything the correct way.
>
> Anybody got an insight here?
The implementation is overly optimistic. Doing, for example,
(when frame-inherited-parameters
(sit-for 0.5)
(dolist (param frame-inherited-parameters)
(unless (assq param parameters)
(let ((val (frame-parameter oldframe param)))
(when val (set-frame-parameter frame param val))))))
works here. I see two ways to fix this. Add such a timeout or, more
cleanly, merge the inherited parameters into 'params' _before_ calling
`frame-creation-function'. As a rule, never fiddle with frame sizes or
positions before the WM got back to us with the new frame.
martin