[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44384: 27.1; Bug in finder-commentary buffer
From: |
Stephen Berman |
Subject: |
bug#44384: 27.1; Bug in finder-commentary buffer |
Date: |
Mon, 02 Nov 2020 10:41:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On Mon, 02 Nov 2020 04:13:35 +0000 Robert Thorpe
<rt@robertthorpeconsulting.com> wrote:
> The quit feature in the finder-commentary buffer doesn't work. I use
> finder-commentary on a library, e.g. M-x finder-commentary appt. Then I
> switch to the buffer it creates. Now, 'C-h m' tells me that I can press
> "q" to quit it and all other finder buffers. This doesn't work. It
> seems to be because the code is expecting the buffer name to be
> different.
This happens in both emacs-27 and master, but not in 26.3. The
difference is due to this change:
commit 070dd439096c0f72d8f73823649e3c650f31c890
Author: Stefan Kangas <stefankangas@gmail.com>
AuthorDate: Fri Jul 12 00:43:12 2019 +0200
Commit: Eli Zaretskii <eliz@gnu.org>
CommitDate: Sat Jul 20 12:23:07 2019 +0300
Make finder-exit use quit-window (Bug#33610)
* lisp/finder.el (finder-exit): Quit window instead of
deleting. This restores previous contents of the window,
if any, that was usurped by "C-h p" to show the list of
packages.
Before this change (i.e. in 26.3), if the frame is split into two (or
more) windows, `q' does delete the Finder window (but doesn't kill the
buffer). But even there, if the Finder buffer is occupying the sole
window of the frame, then `q' does nothing. This seems to be due to
this change:
commit 96ae4c8fa704b0385d6f2cf10b69bf289e2fb7ef
Author: Chong Yidong <cyd@stupidchicken.com>
AuthorDate: Sun Aug 29 18:15:09 2010 -0400
Commit: Chong Yidong <cyd@stupidchicken.com>
CommitDate: Sun Aug 29 18:15:09 2010 -0400
Merge Finder and package-menu functionality.
* lisp/finder.el: Require `package'.
[...]
(finder-exit): We don't use "*Finder-package*" and "*Finder
Category*" buffers anymore.
Despite this commit message, finder.el still contains this code:
(defun finder-commentary (file)
"Display FILE's commentary section.
FILE should be in a form suitable for passing to `locate-library'."
[...]
(pop-to-buffer "*Finder-package*")
[...])
Steve Berman