[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42966: 28.0.50; vc-dir: wrong backend
From: |
Michael Albinus |
Subject: |
bug#42966: 28.0.50; vc-dir: wrong backend |
Date: |
Sat, 24 Oct 2020 15:41:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> Hi Michael,
Hi Dmitry,
> Not in Tramp, but I see an old change in VC that was most likely
> informed by a performance problem in Tramp.
>
> See the commit a40c87a0093. It adds caching of the result of
> vc-git-root to a VC property 'git-root' on the file name.
This seems to be bug#11757.
> Does the change below still make some scenario perceptibly slower?
>
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index b1880c0f7b..91554bb6d8 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1573,8 +1573,7 @@ vc-git-extra-menu
> (defun vc-git-extra-status-menu () vc-git-extra-menu-map)
>
> (defun vc-git-root (file)
> - (or (vc-file-getprop file 'git-root)
> - (vc-file-setprop file 'git-root (vc-find-root file ".git"))))
> + (vc-find-root file ".git"))
>
> ;; grep-compute-defaults autoloads grep.
> (declare-function grep-read-regexp "grep" ())
I haven't tested. But this means to call process-file several times,
it would be a performance degradation, for sure.
Best regards, Michael.
- bug#42966: 28.0.50; vc-dir: wrong backend, (continued)
- bug#42966: 28.0.50; vc-dir: wrong backend, Lars Ingebrigtsen, 2020/10/16
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/16
- bug#42966: 28.0.50; vc-dir: wrong backend, Lars Ingebrigtsen, 2020/10/17
- bug#42966: 28.0.50; vc-dir: wrong backend, Lars Ingebrigtsen, 2020/10/17
- bug#42966: 28.0.50; vc-dir: wrong backend, Lars Ingebrigtsen, 2020/10/17
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/17
- bug#42966: 28.0.50; vc-dir: wrong backend, Lars Ingebrigtsen, 2020/10/18
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/17
- bug#42966: 28.0.50; vc-dir: wrong backend, Michael Albinus, 2020/10/18
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/23
- bug#42966: 28.0.50; vc-dir: wrong backend,
Michael Albinus <=
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/24
- bug#42966: 28.0.50; vc-dir: wrong backend, Michael Albinus, 2020/10/25
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/26
- bug#42966: 28.0.50; vc-dir: wrong backend, Michael Albinus, 2020/10/26
- bug#42966: (no subject), Lars Ingebrigtsen, 2020/10/26
- bug#42966: (no subject), Lars Ingebrigtsen, 2020/10/26
- bug#42966:, Dmitry Gutov, 2020/10/26
- bug#42966:, Lars Ingebrigtsen, 2020/10/26
- bug#42966:, Dmitry Gutov, 2020/10/26
- bug#42966: 28.0.50; vc-dir: wrong backend, Dmitry Gutov, 2020/10/26