[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43714: 28.1: auto-revert code improvements [PATCH]
From: |
Boruch Baum |
Subject: |
bug#43714: 28.1: auto-revert code improvements [PATCH] |
Date: |
Wed, 30 Sep 2020 14:33:44 -0400 |
User-agent: |
NeoMutt/20180716 |
On 2020-09-30 13:41, Glenn Morris wrote:
> The mailing list archives around the time of a commit are often informative.
> https://lists.gnu.org/r/emacs-devel/2005-05/msg01414.html
Absolutely great, Glenn!
An obvious follow-up observation: The patch that was applied was for
Luc's option #3, but it seems to me that the honest solution to the
problem with timers is his option #2, to put the fix in timers. Was that
ever done?
I'm guessing a decision at some point was made not to pursue Luc's
option #2 because the emacs documentation for timers[1] says, "If a
timer function calls functions that can change the match data, it should
save and restore the match data. See Saving Match Data". Reconsidering
that decision could be of benefit emacs-wide.
Attached is a new version of the patch, with the 'save-match-data'
restored. Thanks again, Glenn.
[1] https://www.gnu.org/software/emacs/manual/html_node/elisp/Timers.html
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
auto-revert-28-cosmetic.patch
Description: Text Data
- bug#43714: 28.1: auto-revert code improvements [PATCH], (continued)
- bug#43714: 28.1: auto-revert code improvements [PATCH], Eli Zaretskii, 2020/09/30
- bug#43714: 28.1: auto-revert code improvements [PATCH], Boruch Baum, 2020/09/30
- bug#43714: 28.1: auto-revert code improvements [PATCH], Eli Zaretskii, 2020/09/30
- bug#43714: 28.1: auto-revert code improvements [PATCH], Boruch Baum, 2020/09/30
- bug#43714: 28.1: auto-revert code improvements [PATCH], Lars Ingebrigtsen, 2020/09/30
- bug#43714: 28.1: auto-revert code improvements [PATCH], Boruch Baum, 2020/09/30
- bug#43714: 28.1: auto-revert code improvements [PATCH], Michael Albinus, 2020/09/30
bug#43714: 28.1: auto-revert code improvements [PATCH], Boruch Baum, 2020/09/30
bug#43714: [address@hidden: Re: bug#43714: 28.1: auto-revert code improvements [PATCH]], Boruch Baum, 2020/09/30