[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43598: replace-in-string: finishing touches
From: |
Mattias Engdegård |
Subject: |
bug#43598: replace-in-string: finishing touches |
Date: |
Sun, 27 Sep 2020 13:57:35 +0200 |
27 sep. 2020 kl. 13.48 skrev Lars Ingebrigtsen <larsi@gnus.org>:
> Didn't you just move the STRING_MULTIBYTE bits of the test from the
> string_ascii_p function and open-code it into Fstring_search function
> here?
No, look again. Previously, we would loop through all bytes of a unibyte needle
before checking the lengths of a multibyte haystack. With the patch, we always
do the cheap (length) check first. That's why that check had to be moved out of
the helper function.
- bug#43598: replace-in-string: finishing touches, (continued)
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/25
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/26
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/26
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Richard Stallman, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/28
- bug#43598: replace-in-string: finishing touches, Richard Stallman, 2020/09/28
- bug#43598: replace-in-string: finishing touches, Eli Zaretskii, 2020/09/29
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/27
- bug#43598: replace-in-string: finishing touches,
Mattias Engdegård <=
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Eli Zaretskii, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Eli Zaretskii, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/26
bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/26