[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43598: replace-in-string: finishing touches
From: |
Lars Ingebrigtsen |
Subject: |
bug#43598: replace-in-string: finishing touches |
Date: |
Fri, 25 Sep 2020 01:54:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Mattias Engdegård <mattiase@acm.org> writes:
> The new replace-in-string function is welcome but needs a few tweaks
> before we can call it done:
>
> 1. It doesn't quite work correctly with raw bytes:
>
> (replace-in-string "\377" "x" "a\377b")
> => "axb"
> (replace-in-string "\377" "x" "a\377ø")
> => "a\377ø"
I went ahead and checked in a new C-level function string-search, which
should be an efficient way to search for strings in strings (using
memmem, which Emacs has via Gnulib?), and this fixed these corner cases.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/24
- bug#43598: replace-in-string: finishing touches,
Lars Ingebrigtsen <=
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/25
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/25
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/25
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/25
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/26
- bug#43598: replace-in-string: finishing touches, Lars Ingebrigtsen, 2020/09/26
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Richard Stallman, 2020/09/27
- bug#43598: replace-in-string: finishing touches, Mattias Engdegård, 2020/09/28
- bug#43598: replace-in-string: finishing touches, Richard Stallman, 2020/09/28