[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43308: 28.0.50; Improvements to Edit->Search menu
From: |
Eli Zaretskii |
Subject: |
bug#43308: 28.0.50; Improvements to Edit->Search menu |
Date: |
Tue, 22 Sep 2020 17:19:11 +0300 |
> From: Juri Linkov <juri@linkov.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, Ihor Radchenko <yantar92@gmail.com>,
> 43308@debbugs.gnu.org, stefankangas@gmail.com
> Date: Tue, 22 Sep 2020 11:04:58 +0300
>
> >> Why no keybindings are shown for nonincremental menu items?
> >> They still have keybindings, e.g. nonincremental forward search
> >> can be started with 'C-s RET', nonincremental backward search
> >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc.
> >
> > I suppose I could add some explicitly, with :keys.
> > That makes sense. Unfortunately, none show up
> > automatically. It would be good to somehow fix that.
>
> How about the following patch?
But the keys this will show don't invoke the same commands, they
invoke slightly different commands, don't they? I don't think we ever
show keys that invoke a different command, why do this here?
> Another problem is that selecting "Continue Tags Search"
> signals the error:
>
> emacs -Q
> Select "Edit" -> "Search" -> "Continue Tags Search"
>
> Lisp error: (wrong-type-argument commandp fileloop-continue)
I guess this is a leftover from migration to Xref.
> I think "Continue Tags Search" should be disabled when it has no effect.
Yes, it should be.
Thanks.
- bug#43308: 28.0.50; Improvements to Edit->Search menu, (continued)
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Eli Zaretskii, 2020/09/10
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Ihor Radchenko, 2020/09/20
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Eli Zaretskii, 2020/09/20
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/20
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Juri Linkov, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Andreas Schwab, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/21
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Juri Linkov, 2020/09/22
- bug#43308: 28.0.50; Improvements to Edit->Search menu,
Eli Zaretskii <=
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Juri Linkov, 2020/09/22
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Eli Zaretskii, 2020/09/22
- bug#43308: 28.0.50; Improvements to Edit->Search menu, Drew Adams, 2020/09/22
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Juri Linkov, 2020/09/22
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Drew Adams, 2020/09/22
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Eli Zaretskii, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Drew Adams, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Eli Zaretskii, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Drew Adams, 2020/09/26
- bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error, Eli Zaretskii, 2020/09/26