[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from wind
From: |
Lars Ingebrigtsen |
Subject: |
bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook |
Date: |
Tue, 08 Sep 2020 11:57:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> In any case, the timer_check change seems safe, and fixes a (somewhat
>> obscure) segfault, so does anybody object to putting that in?
>
> Which part? There was more than one patch in the discussion.
This bit, but sounds like Pip is preparing a new patch:
diff --git a/src/keyboard.c b/src/keyboard.c
index dab32b1..4ce830d 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -4560,6 +4560,8 @@ timer_check (void)
Lisp_Object tem = Vinhibit_quit;
Vinhibit_quit = Qt;
+ block_input ();
+ turn_on_atimers (false);
/* We use copies of the timers' lists to allow a timer to add itself
again, without locking up Emacs if the newly added timer is
@@ -4573,6 +4575,8 @@ timer_check (void)
else
idle_timers = Qnil;
+ turn_on_atimers (true);
+ unblock_input ();
Vinhibit_quit = tem;
do
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no