[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS
From: |
Eli Zaretskii |
Subject: |
bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS |
Date: |
Mon, 17 Aug 2020 20:05:58 +0300 |
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Mon, 17 Aug 2020 18:11:50 +0200
> Cc: 42904@debbugs.gnu.org, alan@idiocy.org
>
> 17 aug. 2020 kl. 17.55 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > Is something wrong with encode_string_utf_8? It has arguments that
> > allow you to replace invalid bytes into the likes of u+FFFD. Or did I
> > misunderstand the problem you are facing?
>
> No, that's a valid question. I did try that function first, but it had too
> many quirks: doesn't accept a unibyte non-ASCII string, sometimes replaces
> valid characters, doesn't always output UTF-8... It was easier to write a new
> function which encapsulates the common usage case. In addition, the new
> function is short and simple enough that it can easily be verified to be
> correct; encode_string_utf_8 is big and complex.
Well, it is always easier to special-case some use case, but we have
general APIs for a reason. In particular, having several similar but
subtly different functions is confusing and causes mistakes.
And you seem to be saying that encode_string_utf_8 doesn't work as
advertised, which means it should be fixed.
So I would prefer to use encode_string_utf_8 if reasonably practical.
Thanks.
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Andrii Kolomoiets, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS,
Eli Zaretskii <=
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Alan Third, 2020/08/17
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Alan Third, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Alan Third, 2020/08/18
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/20
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Eli Zaretskii, 2020/08/20
- bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS, Mattias Engdegård, 2020/08/20